refactor: suppress warnings #328
Open
+227
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
requested changes
Nov 20, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for working on this! I've left a minor comment. Please also fix the linter errors.
| std::unordered_map<std::string, std::string> defaults; // required | ||
| std::unordered_map<std::string, std::string> overrides; // required | ||
| std::vector<std::string> endpoints; | ||
| std::unordered_map<std::string, std::string> defaults{}; // required |
Member
There was a problem hiding this comment.
We don't need to add {} for everything, at least not for STL containers and std::string. Please try to minimize lines of change like this.
HuaHuaY
reviewed
Nov 20, 2025
| const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec, | ||
| const std::string& location, | ||
| const std::unordered_map<std::string, std::string>& properties) { | ||
| [[maybe_unused]] const TableIdentifier& identifier, |
Contributor
There was a problem hiding this comment.
I think we can remove the parameters' names instead of adding [[maybe_unused]] to keep the code clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings have been suppressed according to the following patterns:
[[maybe_unused]]using base::func.